Open
Conversation
eimrek
requested changes
Nov 18, 2025
Member
eimrek
left a comment
eimrek
left a comment
There was a problem hiding this comment.
Two issues from a quick look:
- packed cell doesn't seem to work correctly for the test file: "folded atoms" too close, and some still outisde the cell. is the test file faulty?
- sometimes one might want to go to a very small isovalue, like 1e-4 or smaller. At the moment this is not allowed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have something working...
Currently the controls and the update loop is somewhat coupled to this 'viewerParams object' - this has some unwanted side-effects (initstep and updatestep are in same loop).
For now the solution is to update the viewerParams if 'cubeText' exists, will work in changing this behaviour in a seperate commit to hopefully address such issues.