Port analysis to new rewrite goals order#1919
Open
proux01 wants to merge 1 commit intomath-comp:masterfrom
Open
Port analysis to new rewrite goals order#1919proux01 wants to merge 1 commit intomath-comp:masterfrom
proux01 wants to merge 1 commit intomath-comp:masterfrom
Conversation
Collaborator
Author
|
@affeldt-aist CI "green", I think this should be merged without waiting too much to avoid too many conflicts. |
Collaborator
Author
|
@4ever2 BTW is it known that ssprove no longer compiles on MC 2.4.0 (the opam file in the repo still claims compatibility with MC 2.3.0) |
Contributor
We test MC 2.3.0 and 2.4.0 in our CI so it should still be compatible. I think the error is due to the mathcomp-word version used. |
Collaborator
Author
|
You're right, thanks, it's indeed using mathcomp-word 3.2 while ssprove requires >= 3.3. #1907 should fix it by moving to 3.4, @affeldt-aist maybe we should merge it in order to retrieve a green CI? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.