fix: Allow external Dockview drags to use root edge drop targets#1153
Open
jrmal99 wants to merge 1 commit intomathuo:masterfrom
Open
fix: Allow external Dockview drags to use root edge drop targets#1153jrmal99 wants to merge 1 commit intomathuo:masterfrom
jrmal99 wants to merge 1 commit intomathuo:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e53dec6:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root edge drop targets currently reject panel drags from another Dockview instance. I'm using multiple Dockview instances and noticed an inconsistency when writing support in my app to transfer tabs between instances.
Dockview already supports external drag handling for group/header/content targets through
onUnhandledDragOverEventandonDidDrop, but the root edge path returns early when panel drag data exists andviewId !== this.id. That makes cross-instance drops inconsistent:This PR makes root edge behavior consistent with the existing external drop flow.
Changes
canDisplayOverlay(...)to only treat panel drags as internal whendata?.viewId === this.idonDrop(...)to only callmoveGroupOrPanel(...)for same-instance dragsBehavior After This Change
onDidDropinstead of attempting an internal moveWhy
This makes Dockview’s root edge targets behave the same way as its other drop targets for external drags, and removes the need for app-side workarounds when supporting cross-instance tab transfer.
Testing
onDidDrop