Draft: Replace logical ids with edit offsets, add edit offsets to slots#15
Open
gabrielbornstein wants to merge 104 commits intomathworks:mainfrom
Open
Draft: Replace logical ids with edit offsets, add edit offsets to slots#15gabrielbornstein wants to merge 104 commits intomathworks:mainfrom
gabrielbornstein wants to merge 104 commits intomathworks:mainfrom
Conversation
added 13 commits
March 4, 2026 13:34
tonyastolfi
reviewed
Mar 19, 2026
| //==#==========+==+=+=++=+++++++++++-+-+--+----- --- -- - - - - | ||
| // | ||
| /*explicit*/ ChangeLogBlock::ChangeLogBlock(u64 owner_id, | ||
| /*explicit*/ ChangeLogBlock::ChangeLogBlock(u64 offset, |
Collaborator
There was a problem hiding this comment.
Giving this one a more descriptive name...
Collaborator
There was a problem hiding this comment.
I'm also wondering if we should wrap this type. I sort of regret not doing this in llfs, with llfs::slot_offset_type. We could use a BATT_STRONG_TYPEDEF, but I'm thinking that maybe even implicit conversion to the primitive type could be problematic.
We can talk about this next time we meet.
… race condition bugs.
…brielbornstein/turtle_kv into gbornste/add-offsets-to-slots
…brielbornstein/turtle_kv into gbornste/add-offsets-to-slots
…nto gbornste/add-offsets-to-slots
…nto gbornste/add-offsets-to-slots
…brielbornstein/turtle_kv into gbornste/add-offsets-to-slots
…brielbornstein/turtle_kv into gbornste/add-offsets-to-slots
…nto gbornste/add-offsets-to-slots
…nto gbornste/add-offsets-to-slots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening up this MR as a draft. I still likely need to make some changes and add some additional tests, just wanted an easy place to look at my diffs and give myself some review.