Add inheritance graphs to docs#171
Merged
dstansby merged 5 commits intomatplotlib:mainfrom Jun 15, 2023
dstansby:inheritance-graphs
Merged
Add inheritance graphs to docs#171dstansby merged 5 commits intomatplotlib:mainfrom dstansby:inheritance-graphs
dstansby merged 5 commits intomatplotlib:mainfrom
dstansby:inheritance-graphs
Conversation
Collaborator
|
Yeah, do you think it's worthwhile? Also: custom plot users will need to inherit from... |
Member
Author
|
I think it's worth it, especially if #167 happens and it gets even more interesting |
samcunliffe
reviewed
Jun 15, 2023
samcunliffe
approved these changes
Jun 15, 2023
Co-authored-by: Sam Cunliffe <samcunliffe@users.noreply.github.com>
Collaborator
|
Do we need @ruaridhg because: co-authored commit? |
Member
Author
|
I think I hit the merge buton, it's just waiting for tests. |
Member
Author
|
@samcunliffe can you try giving this a fresh approve? |
samcunliffe
approved these changes
Jun 15, 2023
Collaborator
|
Diagram looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #169. Here's what it looks like rendered locally for me: