Add encryption event to relevant test rooms#831
Open
Fizzadar wants to merge 1 commit intomatrix-org:mainfrom
Open
Add encryption event to relevant test rooms#831Fizzadar wants to merge 1 commit intomatrix-org:mainfrom
Fizzadar wants to merge 1 commit intomatrix-org:mainfrom
Conversation
Needed for homeservers that only apply E2EE logic (device changes, etc) to shared encrypted rooms, vs. all shared rooms.
Comment on lines
+174
to
+185
| roomID := alice.MustCreateRoom(t, map[string]interface{}{ | ||
| "preset": "public_chat", | ||
| "initial_state": []map[string]interface{}{ | ||
| { | ||
| "type": "m.room.encryption", | ||
| "state_key": "", | ||
| "content": map[string]interface{}{ | ||
| "algorithm": "m.megolm.v1.aes-sha2", | ||
| }, | ||
| }, | ||
| }, | ||
| }) |
Collaborator
There was a problem hiding this comment.
Needed for homeservers that only apply E2EE logic (device changes, etc) to shared encrypted rooms, vs. all shared rooms.
So I don't have to guess or make assumptions from the code, can you be more specific with what that means? How does this work for Synapse?
Making this change, makes it work with babbleserv because xxx?
Does the Matrix spec say anything around this? Does it need a clarification?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for homeservers that only apply E2EE logic (device changes, etc) to shared encrypted rooms, vs. all shared rooms. Namely babbleserv.
Pull Request Checklist
Signed-off-by: Nick @ Beeper (@Fizzadar) <nick@beeper.com)