Clarify that server ACLs are case-insensitive#2334
Draft
velikopter wants to merge 3 commits intomatrix-org:mainfrom
Draft
Clarify that server ACLs are case-insensitive#2334velikopter wants to merge 3 commits intomatrix-org:mainfrom
velikopter wants to merge 3 commits intomatrix-org:mainfrom
Conversation
velikopter
changed the title
turt2live
requested changes
Mar 17, 2026
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
This change looks good to me, but I think it requires an MSC. I've written one and sent it for FCP: matrix-org/matrix-spec-proposals#4436
Member
Also, per MSC: it looks case insensitive |
Contributor
Author
It was case sensitive previously; I PR'd a fix for this to them. This is why the comment says "treated" and not "treats" :) |
Member
|
ah ha, great. It's a good thing that comprehension of words isn't an important skill for technical writing review 🫠 |
Johennes
reviewed
Mar 18, 2026
Contributor
Author
|
Drafting as MSC has not been accepted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
These were implemented case insensitively in Synapse when they were first added: element-hq/synapse@3cf3e08
Some implementations (notably Ruma) treated them case sensitively however.
Signed-off-by: Helix K vel@riseup.net
Preview: https://pr2334--matrix-spec-previews.netlify.app