Merged
Conversation
Contributor
tigt
commented
Jan 31, 2023
tigt
commented
- Depends on Tweak some samples for clarity and better behavior in playgrounds #148 to be consistent with other frameworks — I have no problems editing them back if that doesn’t get merged, however
- Places Marko with the other resumable frameworks (if there’s other logic for how the frameworks are sorted, I’d love to know)
- Updated the contribution guidelines with what I had to figure out to get the Playground URL working
- Some of the Marko playground URLs produce interesting errors — those are bugs on our end, we’ll fix them out of band
Everything except for the TS declarations since I think Dylan ought to weigh in Co-authored-by: Michael Rawlings <mirawlings@ebay.com> Co-authored-by: Luke LaValva <lukelavalva@gmail.com>
Contributor
Author
|
Oh, uh, I’d be happy to fix up my WIP commit history if your repo doesn’t squash upon merge |
Owner
|
Thanks a lot ! Hope we can find a solution to #148 PR, then I'll review it |
Owner
|
If you can submit this PR without playground issues, we'll be able to add Marko. |
Contributor
Author
|
Roger. Might be a little bit before I get that update in — just left eBay |
Contributor
Author
|
Okay, I changed the Viewport Size and mixed checkbox examples back to Page Title and autofocused input. |
yugo969
pushed a commit
to yugo969/component-party.dev
that referenced
this pull request
Jun 6, 2025
* WIP: add Marko * WTF, vscode * Consistent final newlines * Apply suggestions from code review Everything except for the TS declarations since I think Dylan ought to weigh in Co-authored-by: Michael Rawlings <mirawlings@ebay.com> Co-authored-by: Luke LaValva <lukelavalva@gmail.com> * Feedback: no space before method parens, no TS, else-if, ColorSelect works now * Pre-bugbash updates * This is probably why they want us to provide a linter * Finishing touches * Argle * @rturnq feedback * Match examples to other frameworks --------- Co-authored-by: Michael Rawlings <mirawlings@ebay.com> Co-authored-by: Luke LaValva <lukelavalva@gmail.com> Co-authored-by: tigt <tigt@mortropolis.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.