refactor: shared AuthMethodFields component#54
Merged
matthiastjong merged 1 commit intomainfrom Apr 9, 2026
Merged
Conversation
Unify auth method form fields into a single shared component used by both the target create flow and target detail page. This fixes the create dialog missing JWT ES256 and OAuth2 Refresh Token options, and adds multi-header support for custom_header auth in the create flow. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AuthMethodFieldscomponent (src/lib/components/auth-method-fields.svelte)What changed
src/lib/components/auth-method-fields.svelte— shared component with all auth type options and credential fieldssrc/routes/(app)/targets/+page.svelte— replaced ~130 lines of inline auth fields with shared componentsrc/routes/(app)/targets/[slug]/+page.svelte— replaced ~440 lines of duplicated auth fields (add + edit) with shared componentsrc/routes/(app)/targets/+page.server.ts— added handling forcustom_header(multi-header JSON),jwt_es256, andoauth2_refresh_tokentypesTest plan
🤖 Generated with Claude Code