Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the availability checks for SystemLanguageModel-based tests so that on macOS 15 / Xcode 26.2 the tests are correctly skipped instead of crashing.
Changes:
- Introduced file-scoped helper booleans that check
SystemLanguageModel.default.isAvailableonly within anif #available(macOS 26.0, *)guard. - Updated the
@Testannotations in the affected test files to use these helper booleans for their.enabled(if:)conditions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Tests/AnyLanguageModelTests/APICompatibilityFoundationModelsTests.swift | Adds a guarded isFoundationModelsSystemLanguageModelAvailable helper and uses it to conditionally enable the FoundationModels drop-in compatibility test. |
| Tests/AnyLanguageModelTests/APICompatibilityAnyLanguageModelTests.swift | Adds a guarded isSystemLanguageModelAvailable helper and uses it to conditionally enable the AnyLanguageModel drop-in compatibility test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before making these changes, the tests would crash when targeting my macOS 15 computer in Xcode 26.2.
After the changes, the tests are correctly skipped and the test suite passes.