feat(bridgev2): receive room account data via double puppet /sync loop#481
Draft
kalix127 wants to merge 1 commit intomautrix:mainfrom
Draft
feat(bridgev2): receive room account data via double puppet /sync loop#481kalix127 wants to merge 1 commit intomautrix:mainfrom
kalix127 wants to merge 1 commit intomautrix:mainfrom
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/syncloop as the double-puppeted user to receive room account data changes (m.marked_unread,m.tag,com.beeper.mute)MarkAccountDataSentcalls in intent methods (MarkRead,MarkUnread,TagRoom,MuteRoom) to track bridge-originated changesAccountDataSyncStopperinterface so the sync loop is stopped when double puppeting is disabledManual testing results
Tested end-to-end with mautrix-whatsapp on Synapse with double puppeting configured. Account data events (
m.marked_unread) are correctly received by the sync loop and dispatched to the bridge connector. Loop avoidance works, bridge-originated events are skipped by content comparison, and delayed Synapse re-deliveries (observed up to 3+ minutes late) are also handled correctly.Test plan
m.marked_unreadvia double puppet -> sync echo is skipped (no infinite loop)Fixes #479
Found while fixing mautrix/whatsapp#891