Skip to content

Fix container issue on live page before it goes live live#2998

Open
lvachon1 wants to merge 1 commit intomainfrom
lev/fix/remove_preview_container
Open

Fix container issue on live page before it goes live live#2998
lvachon1 wants to merge 1 commit intomainfrom
lev/fix/remove_preview_container

Conversation

@lvachon1
Copy link
Contributor

@lvachon1 lvachon1 commented Mar 5, 2026

Scope

Asana Ticket: ⚽️ Fix container issue on live page before it goes live live

Implementation

Stopped the preview page from assuming it's children pages wanted a container wrapper, child pages will supply their own now. Removed now redundant param that disabled the container.

Screenshots

How to test

http://localhost:4001/preview/ - Everything looks the same

…ontainer wrapper, child pages will supply their own now. Removed now redundant param that disabled the container.
@lvachon1 lvachon1 requested a review from a team as a code owner March 5, 2026 20:14
@lvachon1 lvachon1 requested a review from joshlarson March 5, 2026 20:14
Copy link
Contributor

@joshlarson joshlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the scope here needs to be a bit wider - this PR will fix the container issue for live views that are still in preview, but not for live views that are out of preview mode and use the regular live layout, which also indiscriminately wraps its inner block in a container.

The solution that I'm thinking is...:

  • Update the live layout so that it no longer wraps its contents in <div class="container">...</div>.
    • (Possibly at this point, we just delete the live layout, because it's not doing anything. In theory, we could keep it, in case we ever decide that we need or want a shared live view layout that's separate from non-live-view pages, but that seems pretty unlikely to me)
  • Update the live views that currently use the live layout to wrap themselves in their own <div class="container">...</div>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants