Only show later-today delays if they are single tracking#3000
Open
Only show later-today delays if they are single tracking#3000
Conversation
jlucytan
force-pushed
the
jlt/alerts/upcoming-delay-status
branch
from
a12f2bd to
bbb2d0c
Compare
joshlarson
requested changes
Mar 6, 2026
Contributor
joshlarson
left a comment
joshlarson
left a comment
There was a problem hiding this comment.
This appears to be filtering out later-today alerts in general, but we only want to be filtering out later-today delays (alert.effect == :delay). Other alert types, like :suspension, :shuttle, etc, should still show up even if they're later in the day.
Contributor
Author
|
@joshlarson updated the code, test is flaky but I haven't been able to hunt down the source, although some of it might've been due to having the server running while running the tests? Got way fewer failures for some reason after turning it off anyway 🙃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: Don't show later-today delays in current subway status
Implementation
Filters out delays from current Subway Status unless they are either currently active, or due to single tracking.
Screenshots
Before
After
Future delays still appear as "planned work"
How to test
Visit the home page and the alerts page while having relevant alerts created. The alerts page seems to cache the alerts locally so you may have to restart the server.