Skip to content

addressClipper rewrite#37

Open
elemongw wants to merge 2 commits intomcwhitak:masterfrom
elemongw:master
Open

addressClipper rewrite#37
elemongw wants to merge 2 commits intomcwhitak:masterfrom
elemongw:master

Conversation

@elemongw
Copy link
Copy Markdown

@elemongw elemongw commented Mar 1, 2016

The commit messages are pretty self-explanatory, both changes were needed for that app to work for me

elemongw added 2 commits March 1, 2016 23:10
It now works for phone numbers outside US.
Trying to convert a null object to lowercase results in an exception.
@mcwhitak
Copy link
Copy Markdown
Owner

mcwhitak commented Mar 2, 2016

I'll build it this weekend and merge it after verifying it. For the app credits would you like to be listed by your github username or a different name?

Theres another pull request someone submitted back on the old format of the app (when we were using ADT instead of android-studio/gradle) that I still haven't updated on the store app. Hopefully within a week or so I can remember to put the new version up.

Thanks for adding this.

@elemongw
Copy link
Copy Markdown
Author

elemongw commented Mar 2, 2016

Github username is fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants