feat(lint): remove MDN URLs duplicated from ancestor#29242
Merged
Conversation
github-actions
Bot
added
infra
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
Contributor
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
Bot
added
merge conflicts 🚧
caugner
force-pushed
the
remove-mdn-urls-duplicated-from-ancestor
branch
from
f87791d to
de80947
Compare
Prepares for adding ancestor mdn_url inheritance checks, which requires access to the full hierarchy.
Move slugs, slugByPath, and redirects computation from test-mdn-urls.js into utils/mdn-content-inventory.js. The wrapper exports a mutable inventory object, making it possible to inject mock data in tests.
Add tests for mdn_url_redirect, mdn_url_casing, mdn_url_404, mdn_url_other_page, mdn_url_casing_hash, and mdn_url_new_page using the mutable inventory wrapper for mock injection. Update existing duplicate_ancestor tests to use mocked inventory as well.
caugner
force-pushed
the
remove-mdn-urls-duplicated-from-ancestor
branch
from
de80947 to
c760506
Compare
LeoMcA
reviewed
Mar 24, 2026
Member
LeoMcA
left a comment
LeoMcA
left a comment
There was a problem hiding this comment.
Code looks fine aside from one duplicated test, but I think the data changes need further review from a BCD maintainer
LeoMcA
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the linter, removing MDN URLs duplicate from ancestor.
Test results and supporting details
This avoids cases where nested subfeatures have exactly the same MDN URL as an ancestor. In these cases, the MDN URL is most definitely not specifically about the subfeature.
Related issues