Conversation
…precated SearchService
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughDocumentation for the Symfony getting-started guide was updated to remove use of a non-existent Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@louisboulagnon @norkunas thanks for reporting this! Could you take a look at this PR and let us know if it addresses the issues you raised? |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@getting_started/frameworks/symfony.mdx`:
- Around line 115-133: Update the SearchController::search method to use the new
SearchManagerInterface::search signature: remove the EntityManagerInterface
parameter from the controller method signature and from the call to
$searchManager->search, and call $searchManager->search with the entity class
and query string (e.g., Movie::class, 'matrix') so the method uses
SearchManagerInterface::search(Movie::class, 'matrix') instead of passing an
EntityManagerInterface instance.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d6f5f157-9d72-4c0d-ac78-fd7bbacc2d70
📒 Files selected for processing (1)
getting_started/frameworks/symfony.mdx
| SearchManagerInterface $searchManager | ||
| ): Response { | ||
| $results = $searchManager->search( | ||
| $entityManager, |
There was a problem hiding this comment.
Well the new search manager removed the need to provide the entity manager, so it can work with any source, not only orm ;)
| ```php | ||
| $results = $searchService->search( | ||
| $results = $searchManager->search( | ||
| $entityManager, |
|
Thanks for having addressed this so quickly 😄 |
Closes #3529
Changes
#[Searchable]attribute — this PHP attribute does not exist in the bundle (tracked in Support attributes to configure indices/indexes meilisearch-symfony#387). Entity configuration is now shown via YAMLindicesinmeilisearch.yaml, which is the only supported approach.SearchServicewithSearchManagerInterface(deprecated since bundle v0.16). Updated both the basic search example and the search with filters example.search()call signature — the current API requiresEntityManagerInterfaceas the first argument:$searchManager->search($entityManager, Movie::class, 'query').Summary by CodeRabbit