Merged
Conversation
Upstream type issues in vite, vitest, and @types/node are now resolved. The only remaining error was in gamepad.ts where ButtonBinding.threshold needed `| undefined` added to the optional property type. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Re-enables TypeScript’s exactOptionalPropertyTypes in the shared base tsconfig now that upstream dependency type issues are resolved, and adjusts the single in-repo type that required an update (gamepad.ts) to compile cleanly under the stricter optional-property semantics.
Changes:
- Turn
exactOptionalPropertyTypes: trueback on inpackages/tsconfig/base.json. - Update
ButtonBinding.thresholdtyping ingamepad.tsto allow explicitundefinedassignment underexactOptionalPropertyTypes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/tsconfig/base.json | Re-enables exactOptionalPropertyTypes for all packages extending the shared config. |
| packages/melonjs/src/input/gamepad.ts | Adjusts ButtonBinding.threshold type to remain assignable when threshold is explicitly set to undefined. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exactOptionalPropertyTypes: truein the shared tsconfiggamepad.ts(ButtonBinding.thresholdneeded| undefined)Closes #1271
Test plan
🤖 Generated with Claude Code