Conversation
RayProud
requested review from
augustoccesar and
Copilot
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue with duplicate thread entries in the linkup health list by introducing logic to filter out duplicate process commands.
- Introduces a helper function, is_child_of_current_process, to exclude child processes from orphan checks.
- Adds a HashSet (seen_commands) to filter out duplicate command strings within the orphan process detection.
Comments suppressed due to low confidence (1)
linkup-cli/src/commands/health.rs:210
- [nitpick] The term 'thread-duplicates' in the comment is ambiguous since the code filters duplicate process commands. Consider clarifying the comment to accurately reflect whether it refers to duplicate processes or threads.
// If there are thread-duplicates, ignore them
augustoccesar
approved these changes
Apr 28, 2025
RayProud
deleted the
romanprudnikov/ship-2074-fix-output-of-linkup-health-on-linux
branch
augustoccesar
added a commit
that referenced
this pull request
May 5, 2025
This release gets the Linux version closer to the macOS. We are testing it with Ubuntu. Main changes: - Ensure that Linkup can bind to 80/443 on Linux - #232 (fixes: 34f5282, 7e8cef5, b6fac77) - Manage self-signed certificates on Linux - #234 - Fix `health` command output on Linux - #236 Other changes: - Fix install script link on docs (8e6009d) - Use Ruff formatting on install script (e39de86) - Don't propagate `baggage` header (#237 ) --------- Co-authored-by: Roman Prudnikov <stillerr@yandex.ru> Co-authored-by: Oliver Stenbom <oliver@stenbom.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS doesn’t expose each thread as a “full” process.
However, Linux does. Which results in lots of thread-duplicates on
linkup healthon Linux.From the Apple documentation
Whereas in Linux, a thread is a process on its own.