Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
vzaslavsky
left a comment
vzaslavsky
left a comment
There was a problem hiding this comment.
Looks better! There're just two little problems that slipped through, and a few minor things that caught my eye.
| public scrollToTerraform(): void { | ||
| const terraformCard = document.querySelector('mst-card'); | ||
| if (terraformCard) { | ||
| terraformCard.scrollIntoView({ behavior: 'smooth', block: 'start' }); |
There was a problem hiding this comment.
This just needs to take into account the fixed header, otherwise it looks like this:
You can do that e.g. by applying the scroll-mt-[100px] class to the mst-card.
| </div> | ||
|
|
||
| <!-- Action Buttons --> | ||
| <div class="hidden md:flex items-center gap-2"> |
There was a problem hiding this comment.
The link looks, indeed, way better. Would changing their order and increasing the distance between them make it even better?
| <div class="hidden md:flex items-center flex-row-reverse gap-4"> |
Also, does it make sense to make it look close to the Github link, with the icon and border?
| </mst-card> | ||
| </div> | ||
|
|
||
| <!-- Option 2: Manual Terraform Setup --> |
There was a problem hiding this comment.
It seems like this view lost the "Import via UI" block on the left hand side, and the "View Source Code" button is also gone. Oh, and there are slight differences, like colour of the steps, between the card here and the new one.
| type="button" | ||
| (click)="scrollToTerraform()" | ||
| class="flex items-center justify-center px-4 py-2 bg-primary-600 hover:bg-primary-700 text-white rounded-lg font-medium transition-colors whitespace-nowrap"> | ||
| <span>Use as Code</span> |
There was a problem hiding this comment.
Would you like to add the icons?
<i class="fas fa-code mr-2"></I>
<i class="fas fa-window-restore mr-2"></I>
I realise the second button looks weird. Perhaps, fa-plus or losing "via UI" would make it look nicer.
2 participants
No description provided.