Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds persisted WiFi credentials to the companion_radio example and exposes them via the CLI rescue interface so WiFi can be reconfigured without recompiling firmware.
Changes:
- Extend
NodePrefswith persistedwifi_ssid/wifi_pwdfields. - Persist/load WiFi credentials in
DataStoreand use them during ESP32 WiFi startup. - Add CLI rescue commands to set/get WiFi SSID/password and restart WiFi after updates.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| examples/companion_radio/NodePrefs.h | Adds persisted fields for WiFi SSID/password. |
| examples/companion_radio/DataStore.cpp | Saves/loads the new WiFi fields as part of prefs storage. |
| examples/companion_radio/MyMesh.cpp | Adds “effective WiFi creds” helpers, WiFi restart helper, and CLI rescue set/get commands. |
| examples/companion_radio/main.cpp | Uses persisted WiFi credentials (fallback to build-time) when starting WiFi on ESP32. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
df9280d to
5e23630
Compare
5e23630 to
e43c584
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small PR that enables configuring wifi over CLI.
ref: #917