Enable GPS time sync for ThinkNode M1 repeater builds 🤖🤖#2256
Open
TerryFrench wants to merge 1 commit intomeshcore-dev:devfrom
Open
Enable GPS time sync for ThinkNode M1 repeater builds 🤖🤖#2256TerryFrench wants to merge 1 commit intomeshcore-dev:devfrom
TerryFrench wants to merge 1 commit intomeshcore-dev:devfrom
Conversation
Add PERSISTANT_GPS and ENV_SKIP_GPS_DETECT flags to the ThinkNode M1 repeater build so the GPS module is active from boot and automatically syncs the RTC clock. Without these flags, GPS detection fails on cold-starting GPS modules that need more than 1 second to begin outputting NMEA data, causing gps_detected=false and hiding all GPS CLI commands. The existing MicroNMEALocationProvider already handles initial sync after fix acquisition and periodic re-sync every 30 minutes - these flags just ensure it is enabled. Relates to meshcore-dev#1426 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PERSISTANT_GPS=1andENV_SKIP_GPS_DETECT=1build flags to[env:ThinkNode_M1_repeater]invariants/thinknode_m1/platformio.iniDetails
The ThinkNode M1 has GPS hardware (pins 40/41, enable pin 34, reset pin 37) and its
target.cppcreates aMicroNMEALocationProvider, but the repeater build lacks the flags to bypass the 1-second GPS detection window at boot. Cold-starting GPS modules miss this window, causinggps_detected=falseand hiding all GPS CLI commands.With these flags, GPS is assumed present and stays active, letting the existing
MicroNMEALocationProvidersync the RTC automatically on fix (~30-90s) and re-sync every 30 minutes.Relates to #1426
Community discussion
Change
Two build flags added to
[env:ThinkNode_M1_repeater]invariants/thinknode_m1/platformio.iniTesting
Not yet tested on physical ThinkNode M1 hardware — change is identical in nature to the Station G2 fix (#2255) which was verified on hardware.
🤖 Generated with Claude Code