fix test after WorkerInfo update in pytorch/pytorch#1528
Merged
divyanshk merged 1 commit intometa-pytorch:mainfrom Feb 19, 2026
Merged
fix test after WorkerInfo update in pytorch/pytorch#1528divyanshk merged 1 commit intometa-pytorch:mainfrom
divyanshk merged 1 commit intometa-pytorch:mainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will land after pytorch/pytorch#174106
In the above PR we make
WorkerInfoa frozendataclass. The unit test will fail because changing the attribute raises a FrozenInstanceError which is not an instance of RuntimeError. Removing these lines to keep parity with above PR.General note: the stateful_dataloder/test_dataloader.py have diverged a bit from pytorch/test/test_dataloader.py. Eventually we need to get them at par.