Skip to content

Add GROMACS simulation engine#130

Merged
Luthaf merged 6 commits intomainfrom
gromacs
Mar 24, 2026
Merged

Add GROMACS simulation engine#130
Luthaf merged 6 commits intomainfrom
gromacs

Conversation

@PicoCentauri
Copy link
Copy Markdown
Contributor

@PicoCentauri PicoCentauri commented Dec 10, 2025

Added installation instructions for the GROMACS engine.

Contributor (creator of pull-request) checklist

- [ ] Tests updated (for new features and bugfixes)?

  • Documentation updated (for new features)?
    - [ ] Issue referenced (for PRs that solve an issue)?

Reviewer checklist

  • CHANGELOG updated with public API or any other important changes?

📚 Download documentation for this pull-request

Comment thread docs/src/outputs/energy.rst Outdated
Copy link
Copy Markdown
Member

@HaoZeke HaoZeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @PicoCentauri

Comment thread docs/src/engines/gromacs.rst Outdated
@PicoCentauri
Copy link
Copy Markdown
Contributor Author

We have to add the recent changes like variants before we release

@HaoZeke
Copy link
Copy Markdown
Member

HaoZeke commented Jan 31, 2026

We have to add the recent changes like variants before we release

Yup and get these on the channel
https://github.com/metatensor/gromacs-metatomic-feedstock/tree/main

(would be OK being a recipe maintainer BTW?)

@PicoCentauri
Copy link
Copy Markdown
Contributor Author

Yes sure.

@PicoCentauri PicoCentauri force-pushed the gromacs branch 2 times, most recently from 172c9ad to 1f52f3c Compare February 2, 2026 10:57
@PicoCentauri PicoCentauri marked this pull request as ready for review March 18, 2026 13:48
@PicoCentauri PicoCentauri requested a review from Luthaf March 18, 2026 14:46
Comment thread docs/src/engines/gromacs.rst Outdated
cmake .. \
-DCMAKE_PREFIX_PATH="$CMAKE_PREFIX_PATH" \
-DTorch_DIR=$TORCH_PREFIX \
-DGMX_METATOMIC=AUTO
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this AUTO and not ON?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parity with nnpot

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does AUTO means in this case? In general, I don't think parity with nnpot should be a goal for us. We can take some inspiration from them, but we can do our own thing if it is better.

Do other "plugins" to GROMACS use a similar pattern?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto just means if the dependencies are present we enable it.. I think for now we can merge this and handle it in a follow up.

Comment thread docs/src/engines/gromacs.rst Outdated
on a subgroup (ML/MM) with interatomic potentials in the metatomic format.

How to install the code
^^^^^^^^^^^^^^^^^^^^^^^
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a section on how to get the code from conda, and how to pick the correct build?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes same as for lammps. I will ad tomorrow

@PicoCentauri PicoCentauri requested a review from Luthaf March 20, 2026 07:29
@Luthaf Luthaf merged commit d403c34 into main Mar 24, 2026
9 checks passed
@Luthaf Luthaf deleted the gromacs branch March 24, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants