Conversation
HaoZeke
left a comment
There was a problem hiding this comment.
Awesome, thanks @PicoCentauri
|
We have to add the recent changes like variants before we release |
Yup and get these on the channel (would be OK being a recipe maintainer BTW?) |
|
Yes sure. |
172c9ad to
1f52f3c
Compare
| cmake .. \ | ||
| -DCMAKE_PREFIX_PATH="$CMAKE_PREFIX_PATH" \ | ||
| -DTorch_DIR=$TORCH_PREFIX \ | ||
| -DGMX_METATOMIC=AUTO |
There was a problem hiding this comment.
What does AUTO means in this case? In general, I don't think parity with nnpot should be a goal for us. We can take some inspiration from them, but we can do our own thing if it is better.
Do other "plugins" to GROMACS use a similar pattern?
There was a problem hiding this comment.
Auto just means if the dependencies are present we enable it.. I think for now we can merge this and handle it in a follow up.
| on a subgroup (ML/MM) with interatomic potentials in the metatomic format. | ||
|
|
||
| How to install the code | ||
| ^^^^^^^^^^^^^^^^^^^^^^^ |
There was a problem hiding this comment.
Could you add a section on how to get the code from conda, and how to pick the correct build?
There was a problem hiding this comment.
Yes same as for lammps. I will ad tomorrow
Co-authored-by: Guillaume Fraux <guillaume.fraux@epfl.ch>
Added installation instructions for the GROMACS engine.
Contributor (creator of pull-request) checklist
- [ ] Tests updated (for new features and bugfixes)?- [ ] Issue referenced (for PRs that solve an issue)?Reviewer checklist
📚 Download documentation for this pull-request