Apply realization clustering result to any lead time#2340
Merged
mo-jbeaver merged 10 commits intometoppv:masterfrom Apr 17, 2026
Merged
Apply realization clustering result to any lead time#2340mo-jbeaver merged 10 commits intometoppv:masterfrom
mo-jbeaver merged 10 commits intometoppv:masterfrom
Conversation
maxwhitemet
reviewed
Mar 26, 2026
Contributor
There was a problem hiding this comment.
Nicely done @gavinevans. I've added some minor comments. An aside: the branch needs to be rebased.
maxwhitemet
previously approved these changes
Apr 8, 2026
Contributor
maxwhitemet
left a comment
maxwhitemet
left a comment
There was a problem hiding this comment.
Thanks Gavin. Happy with the changes made so approved. I've added some very minor comments that shouldn't stop this work from moving to second review.
gavinevans
force-pushed
the
mobt_1073_apply_clustering2
branch
from
45c6046 to
8d408d6
Compare
maxwhitemet
previously approved these changes
Apr 8, 2026
Contributor
maxwhitemet
left a comment
maxwhitemet
left a comment
There was a problem hiding this comment.
Thanks @gavinevans. Happy with the changes made. Approved 👍
mo-jbeaver
requested changes
Apr 16, 2026
Contributor
mo-jbeaver
left a comment
mo-jbeaver
left a comment
There was a problem hiding this comment.
Some comments added about potential things to include.
Tests ran successfully.
gavinevans
force-pushed
the
mobt_1073_apply_clustering2
branch
from
8d408d6 to
1249033
Compare
mo-jbeaver
approved these changes
Apr 17, 2026
Contributor
mo-jbeaver
left a comment
mo-jbeaver
left a comment
There was a problem hiding this comment.
Happy with all the changes and tests ran successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/metoppv/mo-blue-team/issues/1073
Related to: #2259
Description
This PR adds a plugin and CLI that applies the result of the realization clustering that was diagnosed as part of the RealizationClusterAndMatch plugin to a set of forecasts, likely from a forecast period that was not included within the initial realization clustering. This allows the RealizationClusterAndMatch plugin to take a subset of all lead times to diagnose the realization clustering with the RealizationSelection plugin then being used to apply the clustering and matching to other lead times. To support this work, an additional attribute has been added to the RealizationClusterAndMatch plugin:
primary_input_realization_to_cluster_medoid, so that the cluster medoid is recorded for "primary input" e.g. the forecast source available to the longest lead time and, therefore the forecast source that was clustered as part of the RealizationClusterAndMatch plugin.Testing: