Conversation
🎭 Playwright tests failedThe Playwright tests failed on this PR. Please check the test results and fix any issues. |
|
On main and in this PR I get the same number of errors with
|
|
Thanks for starting this. What do you think the failing playwright test is about? |
There was a problem hiding this comment.
Pull request overview
Updates the project’s SvelteKit toolchain to support TypeScript 6 and removes the package-level TypeScript peer dependency.
Changes:
- Bump SvelteKit and related Svelte tooling versions and update TypeScript to
^6.0.2. - Remove
typescriptfrompeerDependencies, leavingsvelteas the only peer dependency. - Regenerate
package-lock.jsonto reflect the dependency upgrades.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Upgrades Svelte/SvelteKit/TypeScript dev deps and removes the TypeScript peer dependency. |
| package-lock.json | Updates the resolved dependency graph for the upgraded Svelte/SvelteKit/TypeScript toolchain. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "engines": { | ||
| "node": "^20.17.0 || >=22.9.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "svelte": ">=5", | ||
| "typescript": "^5.0.2" | ||
| "svelte": ">=5" | ||
| }, |
There was a problem hiding this comment.
engines.node currently allows Node ^20.17.0 || >=22.9.0, but the updated toolchain in this PR pulls in Vite 7.x which requires Node ^20.19.0 || >=22.12.0 (per package-lock.json). This mismatch can cause installs to fail under engine-strict setups or mislead users about supported Node versions. Consider bumping the engine range to match the strictest dependency requirement (or pinning Vite/@sveltejs/vite-plugin-svelte to versions compatible with the current engine range).
There was a problem hiding this comment.
Sveltekit has
"engines": {
"node": ">=18.13"
}
Maybe we don't need to pin node anymore in Layer Cake?
Looks like some node actions being outdated issues maybe? https://github.com/mhkeller/layercake/actions/runs/24331283820/job/71037519592 I'll try and see if an update fixes it. |
🎭 Playwright tests failedThe Playwright tests failed on this PR. Please check the test results and fix any issues. |
|
Ok, seems to have been an issue with npm changing something about I tried a workaround with pinning to a sub-version from: There was a fix here with more details on the issue: Do you remember why we needed an update to 11, @mhkeller? |
I removed the npm install and it seems to also run with the default npm 10.9.7 included in the image. |
SvelteKit supports TypeScript 6 so I think it might be possible to remove the peer dependency for
"typescript": "^5.0.2"in Layer Cake.There are a bunch of changes in the Kit PR which haven't yet dug into (changes to config options, e.g.
strictis removed, and some type declarations are removed, like/** @type {import('./$types').PageServerLoad} */):sveltejs/kit#15595