added lock to put_image in ndtiff dataset. Heavy threaded writing did…#178
Open
LukasMicroscopy wants to merge 1 commit intomicro-manager:mainfrom
Open
added lock to put_image in ndtiff dataset. Heavy threaded writing did…#178LukasMicroscopy wants to merge 1 commit intomicro-manager:mainfrom
LukasMicroscopy wants to merge 1 commit intomicro-manager:mainfrom
Conversation
… lead to double file creation and corrupted files. The lock solves this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… lead to double file creation and corrupted files. The lock solves this.
When ndtiff-dataset was used in a threaded way (A python thread writes images with put_image whenever one is available in a queue). Occasionally, the ndtiff file where corrupted or two new ndtiff file writer where created at once. The lock prevents the execution of the put_image function twice, before the last one finished. This happens even with global interpreter lock, since the execution of the function is not serialized