Do not prefix camera metadata with label#833
Conversation
|
Regarding the breaking change: Given that devices get a default label equal to their name, one possibility is to add prefixes like Question would be whether to do this only for non-standard properties (I think yes). |
|
Ok, here's a better plan: Andor
AndorSDK3 The existing code prefixes the tags with
PICAM
PrincetonInstruments This adapter is obsolete and not in any build. Should remove the whole adapter. PVCAM As stated above, only commented code is updated here. RaptorEPIX, HoribaEPIX All custom keys; prefix with TIScam
TwoPhoton
|
Fix the minority of cameras that use metadata keys "MyLabel-Key" instead of "Key" for some or all fields of the camera-generated metadata. Avoid using MetadataSingleTag and SetTag(); replace with straightforward PutImageTag(). Andor, TwoPhoton: generally replace with fixed name prefix. No prefix for Binning tag. For these cameras, prefixed ElapsedTime-ms and ImageNumber contain distinct information from the standard unprefixed tags added by the Core. Keep those separate. TwoPhoton: CameraChannelIndex and CameraChannelName keep the label-prefixed tags, at least for now. Also emit unprefixed. RaptorEPIX, HoribaEPIX: replace label prefix with fixed name prefix; this was only needed for the custom tags (others already used PutImageTag()). AndorSDK3: already had fixed prefix; keep behavior but use PutImageTag(). PICAM, TIScam: remove ElapsedTime-ms and ImageNumber (redundnt with Core); no prefix for Binning tag. PVCAM change is commented code only. The idea behind replacing the camera label prefix with the fixed name prefix is that the camera device name is the default for the camera label. The two may have even been confused during implementation of these tags.
05fb3d6 to
6f4c429
Compare
Fix the minority of cameras that use metadata keys "MyLabel-Key" instead of "Key" for some or all fields of the camera-generated metadata. In the case of TISCam, delete the redundant fields.
Affected cameras: Andor, AndorSDK3, PICAM, PrincetonInstruments, RaptorEPIX (& HoribaEPIX), TIScam, TwoPhoton.
PVCAM change is commented code only.
Fixes #831.