MMCoreJ: refactor java methods and add unit tests metadata handling#835
Merged
marktsuchida merged 2 commits intomicro-manager:mainfrom Feb 13, 2026
Merged
Conversation
For readability of MMCoreJ.i and for testability of the Java methods (especially the ones that generate metadata). Checked with diff to ensure the move methods have not substantially changed. (Assisted by Claude Code; any errors are mine.)
Constrain the current behavior even where it does not seem like the desired behavior, because the details may be relied upon by downstream (especially acquisition engines and datastores). (Assisted by Claude Code; any errors are mine.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move much of the Java code out of the SWIG input
MMCoreJ.iand into 2 package-private classes.Add unit tests for the factored out methods related to metadata handling, so that we know what's happening (including potentially undesirable behavior).