Skip to content

Closes #172 Show user a message when bootc quickstart run with VPN#206

Open
kasturinarra wants to merge 1 commit intomicroshift-io:mainfrom
kasturinarra:fix_issue_172
Open

Closes #172 Show user a message when bootc quickstart run with VPN#206
kasturinarra wants to merge 1 commit intomicroshift-io:mainfrom
kasturinarra:fix_issue_172

Conversation

@kasturinarra
Copy link

@kasturinarra kasturinarra commented Feb 26, 2026

Summary by CodeRabbit

  • New Features
    • Added DNS resolution validation before startup to ensure required registries are reachable.
    • Skips the check for local/air-gapped images to preserve offline workflows.
  • Bug Fixes
    • Retries DNS lookup after a short pause to reduce failures from transient DNS delays.
    • Improved, user-facing error messages with clear remediation steps when resolution fails.

@kasturinarra kasturinarra requested a review from a team as a code owner February 26, 2026 08:39
@coderabbitai
Copy link

coderabbitai bot commented Feb 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8b005b8 and 32d6872.

📒 Files selected for processing (1)
  • src/quickstart.sh
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/quickstart.sh

📝 Walkthrough

Walkthrough

A DNS resolution validation was added to the run_bootc_image function in src/quickstart.sh. The script now tests whether the container can resolve quay.io, retries once after 5s on transient failure, and on repeated failure prints diagnostic guidance, stops the container, and exits non‑zero. Local images (localhost/*) skip the check.

Changes

Cohort / File(s) Summary
DNS Validation
src/quickstart.sh
Added DNS resolution check for quay.io inside the container with a 5s retry; prints detailed DNS/VPN/host DNS troubleshooting guidance and stops/exits on repeated failure. Skips check for localhost/* images.

Sequence Diagram(s)

sequenceDiagram
  participant Host
  participant Container
  participant DNS as "DNS / quay.io"
  Host->>Container: start container (run_bootc_image)
  Container->>DNS: resolve quay.io
  alt resolves
    DNS-->>Container: IP
    Container-->>Host: continue startup
  else fails
    Container-->>Container: sleep 5s
    Container->>DNS: resolve quay.io (retry)
    alt resolves
      DNS-->>Container: IP
      Container-->>Host: continue startup
    else fails again
      Container-->>Host: print DNS/VPN/host DNS diagnostic messages
      Host->>Container: stop container
      Container-->>Host: exit non-zero
    end
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding user messaging when bootc quickstart encounters VPN/DNS issues, which aligns with the DNS validation and error messaging added in the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kasturinarra
Copy link
Author

/hold

@kasturinarra
Copy link
Author

/hold cancel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant