Skip to content

[SPIR-V][vk::SampledTexture] #12. Support vk::SampledTexture3D type.#8213

Merged
luciechoi merged 1 commit intomicrosoft:mainfrom
luciechoi:texture3d
Apr 15, 2026
Merged

[SPIR-V][vk::SampledTexture] #12. Support vk::SampledTexture3D type.#8213
luciechoi merged 1 commit intomicrosoft:mainfrom
luciechoi:texture3d

Conversation

@luciechoi
Copy link
Copy Markdown
Collaborator

Part of #7979

The function definitions are equivalent to that of Texture3D counterparts, just without Sampler argument.

@luciechoi luciechoi changed the title [SPIR-V][vk::SampledTexture] #11. Support vk::SampledTexture3D type. [SPIR-V][vk::SampledTexture] #12. Support vk::SampledTexture3D type. Mar 28, 2026
@luciechoi
Copy link
Copy Markdown
Collaborator Author

(@s-perron @Keenuts this is the next sampled texture PR, I'll add the negative test cases for all the types functions in another CL)

Copy link
Copy Markdown
Collaborator

@s-perron s-perron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions. You can merge once you have them fixed.

Comment thread tools/clang/lib/Sema/SemaHLSL.cpp Outdated
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
Successfully started running 1 pipeline(s).

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
Successfully started running 1 pipeline(s).

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
Successfully started running 1 pipeline(s).

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
Successfully started running 1 pipeline(s).

@luciechoi luciechoi enabled auto-merge (squash) April 14, 2026 21:51
@luciechoi luciechoi requested a review from s-perron April 14, 2026 21:51
@luciechoi luciechoi merged commit 212d85b into microsoft:main Apr 15, 2026
12 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants