[SPIR-V] Remove unnecessary cases for SampledTexture that are breaking builds#8375
Merged
luciechoi merged 3 commits intomicrosoft:mainfrom Apr 15, 2026
Merged
[SPIR-V] Remove unnecessary cases for SampledTexture that are breaking builds#8375luciechoi merged 3 commits intomicrosoft:mainfrom
SampledTexture that are breaking builds#8375luciechoi merged 3 commits intomicrosoft:mainfrom
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
s-perron
approved these changes
Apr 14, 2026
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
s-perron
approved these changes
Apr 14, 2026
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Collaborator
|
The description is not up to date anymore no? |
s-perron
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #7979
These cases aren't needed and should be removed. (previously was failing builds because they weren't wrapped around
#ifdef)GetBasicKindTypemapsArBasicKindvalues to Clang QualType objects. SampledTexture wrappers are not introduced through that mapping table, so it shouldn't be added here (it's a no-op for SampledTexture types).