Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ coverage:
threshold: 1%
informational: true

# Patch coverage (changed lines only) - this will block PRs
# Patch coverage (changed lines only) - blocks PRs if below 90%
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot, we want Patch coverage (changed lines only) to block a PR.
Today, codecov just creates a comment with coverage numbers, but the PR owner can just resolve the comment even if the patch coverage is below 90%.
We want only admins to bypass code coverage check, regular contributors should not be able to just close a comment with failed patch coverage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch coverage is already configured to block PRs with informational: false. This means:

  • Codecov creates a required status check (not just a comment)
  • Regular contributors cannot bypass it
  • Only repository admins can override through GitHub branch protection settings when needed

The configuration was already correct; I've now reverted the project coverage changes per your feedback in 966aba1.

patch:
default:
target: 90%
Expand Down