-
Notifications
You must be signed in to change notification settings - Fork 381
Add macOS support to diskann-platform and diskann-disk #781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
10
commits into
main
Choose a base branch
from
copilot/add-mac-support-to-ci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0b11493
Initial plan
Copilot 8729b55
Add macOS support to diskann-platform and CI
Copilot aad7194
Consolidate libc dependency for Unix-like platforms
Copilot baa4027
Fix macOS compilation issue in diskann-disk
Copilot 262239f
Increase InlineError capacity for macOS mutex size
Copilot b3db96e
Fix macOS CI: use scalar arch instead of x86-64-v3 in SIMD benchmark …
Copilot ad53b80
Use architecture-specific test files for SIMD benchmarks
Copilot 04a5a1a
Fix timer test for macOS platform
Copilot ead2d92
Address code review feedback
Copilot f11d763
Fix doc tests for x86_64 module on ARM macOS
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description mentions a dedicated macOS benchmark CI job (e.g. “test-benchmark-macos”), but this workflow change only adds macos-latest to the existing workspace test matrices. Please either update the PR description to reflect what’s actually in CI, or add the missing macOS benchmark job if that was intended.