Fix Access Reviews contactedReviewers failing with 'Invalid guid'#116
Open
rgunst wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix Access Reviews contactedReviewers failing with 'Invalid guid'#116rgunst wants to merge 1 commit intomicrosoft:mainfrom
rgunst wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The contactedReviewers grandchild endpoint uses a URL template with two <placeholder> tokens: definitions/<placeholder>/instances/<placeholder>/contactedReviewers New-GraphBatchRequest replaces ALL <placeholder> occurrences with the same value (the instance ID), causing both the definition ID and instance ID slots to get the instance ID. This results in 400 errors like "Invalid guid 2G3-4TG6YU2J54hjnaRoPQE passed in" when definition IDs are non-GUID formatted strings. Fix: when _processChildrenRecursive encounters children whose GraphUri contains multiple <placeholder> tokens, it now queues them per parent ID with the first (ancestor) placeholder pre-resolved. This leaves exactly one <placeholder> for the batch request to fill with the correct child ID. Fixes microsoft#115
Author
|
This fix was primarily developed using Claude Code (AI pair programming). I guided the process, validated the code changes, and tested the results against a production tenant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contactedReviewersgrandchild endpoint URL template contains two<placeholder>tokens:definitions/<placeholder>/instances/<placeholder>/contactedReviewersNew-GraphBatchRequestreplaces all<placeholder>occurrences with the same value (the instance ID), so both slots get the instance ID instead of using the definition ID for the first and the instance ID for the secondInvalid guid 2G3-4TG6YU2J54hjnaRoPQE passed inwhen definition IDs use non-GUID formatted stringsChanges
Modified
_processChildrenRecursiveinsrc/Export-Entra.ps1to detect children whoseGraphUricontains multiple<placeholder>tokens. When found, it queues them per parent ID with the first (ancestor) placeholder pre-resolved, leaving exactly one<placeholder>for the batch request to fill with the correct child ID.Test plan
Export-Entra -Type AccessReviews— contactedReviewers URLs now correctly usedefinitions/{defId}/instances/{instanceId}/contactedReviewerswith distinct IDsJoin-Pathchain matches request ID construction for cross-platform compatibilityFixes #115