Skip to content

fix: migrate Docker push from deprecated MSI to WIF service connection#2536

Merged
BrendanWalsh merged 1 commit intomasterfrom
fix-docker-service-connection
Mar 31, 2026
Merged

fix: migrate Docker push from deprecated MSI to WIF service connection#2536
BrendanWalsh merged 1 commit intomasterfrom
fix-docker-service-connection

Conversation

@BrendanWalsh
Copy link
Copy Markdown
Collaborator

Summary

Switches Docker image push steps from the deprecated SynapseML MCR MSI service connection (Managed Service Identity) to the existing SynapseML MCR connection (Workload Identity Federation).

Problem

The SynapseML MCR MSI service connection uses MSI-based auth, which was deprecated by OneBranch in June 2025. The MSI can no longer fetch access tokens on hosted build agents, blocking any Docker image publishing to mmlsparkmcr ACR.

Fix

A WIF-based service connection (SynapseML MCR) already exists in ADO, is ready, and not disabled. This PR simply updates the 3 Docker push steps to reference it:

  • Demo Image Push (line 291)
  • Minimal Image Push (line 299)
  • Release Image Push (line 314)

Verification

After merge, run the pipeline with publishDockerImages: true (no tag) to validate that auth to mmlsparkmcr ACR works. This will push build-demo and build-minimal without touching release.

Related

The 'SynapseML MCR MSI' service connection uses Managed Service Identity
auth, which was deprecated by OneBranch (June 2025). The MSI can no
longer fetch access tokens on hosted agents, blocking Docker image
publishing to mmlsparkmcr ACR.

Switch all three Docker push steps to use the existing 'SynapseML MCR'
service connection, which uses Workload Identity Federation and is
already configured and ready in ADO.

Related: IcM 31000000570827 (CVE-2023-44487 in mmlspark/release)
Copilot AI review requested due to automatic review settings March 31, 2026 07:24
@github-actions
Copy link
Copy Markdown

Hey @BrendanWalsh 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process.
Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix.
This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source.
Check out the developer guide for additional guidance on testing your change.

@github-actions
Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA a884e56.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@BrendanWalsh BrendanWalsh merged commit 1152f50 into master Mar 31, 2026
14 of 15 checks passed
@BrendanWalsh BrendanWalsh deleted the fix-docker-service-connection branch March 31, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant