Skip to content
This repository was archived by the owner on Feb 5, 2026. It is now read-only.

🔁: Updated plugins loading workflow to be able to store them o…#325

Open
fariquelme wants to merge 2 commits intomicrosoft:mainfrom
fariquelme:feature/plugins_rework
Open

🔁: Updated plugins loading workflow to be able to store them o…#325
fariquelme wants to merge 2 commits intomicrosoft:mainfrom
fariquelme:feature/plugins_rework

Conversation

@fariquelme
Copy link
Contributor

🔁: Updated plugins loading workflow to be able to store them on separate directories

@fariquelme
Copy link
Contributor Author

@microsoft-github-policy-service agree

@liqul liqul requested a review from Jack-Q May 6, 2024 03:03
@liqul
Copy link
Collaborator

liqul commented May 6, 2024

Thanks for the contribution.

But we have some concerns with it. I can see it breaking some unit test cases. This might be easy to fix. However, this change makes it incompatible with the existing setting, so there requires an explicit upgrade operation for users who has already been using the code repo. So, the better approach is to support both separated folders and putting files in the plugins folder directly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants