-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[BREAKING] Python: Trim final FRC to match service storage #4803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3115,6 +3115,9 @@ class _ChatOptionsBase(TypedDict, total=False): | |
| # System/instructions | ||
| instructions: str | ||
|
|
||
| # History storage | ||
| store_final_function_result_content: bool | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this common enough to have to be part of the core chat options? not sure I like that, it also is not really a service side setting, which is what is the target for the ChatOptions, so we might want to use |
||
|
|
||
|
Comment on lines
3115
to
+3120
|
||
|
|
||
| if TYPE_CHECKING: | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
store_final_function_result_contentis only read from per-runoptions(viaopts.pop(...)) and does not considerAgent.default_options. If a user sets this flag as a default option, it will (1) be ignored for filtering (ctx value remains False) and (2) be forwarded down toclient.get_response()viaco, potentially breaking clients that reject unknown options. Consider deriving the effective flag from the merged options (run overrides defaults), then removing it from the options dict passed to the client.