Add ADR to decide consistency of Chat History Persistence#4816
Open
westey-m wants to merge 2 commits intomicrosoft:mainfrom
Open
Add ADR to decide consistency of Chat History Persistence#4816westey-m wants to merge 2 commits intomicrosoft:mainfrom
westey-m wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a proposed ADR documenting the current inconsistency between service-side chat history storage and framework ChatHistoryProvider storage when tool-calling loops are involved, and frames decision drivers/options for aligning behavior.
Changes:
- Introduces ADR 0020 describing the discrepancy (persistence timing + trailing
FunctionResultContent) between service-managed and provider-managed history. - Documents two default behavior options (per-run w/ trimming vs per-service-call persistence) with pros/cons and links to related PRs/issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When using an AIAgent today, users get different behaviors based on whether chat history is stored service side or in a ChatHistoryProvider. This can create challenges when e.g. the function call loop is terminated and you want to resume, but you don't now whether the last FunctionResultContent is in the chat history or not.
Description
Contribution Checklist