Add regression coverage for TS SDK refresh after aspire add#16158
Merged
sebastienros merged 4 commits intomainfrom Apr 15, 2026
Merged
Add regression coverage for TS SDK refresh after aspire add#16158sebastienros merged 4 commits intomainfrom
sebastienros merged 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds CLI E2E regression coverage for TypeScript guest AppHost SDK refresh behavior after aspire add, targeting the packaged/prebuilt AppHost server path described in #15785.
Changes:
- Reworks the existing TypeScript codegen E2E test into a scenario that adds an integration and validates SDK refresh via
.codegen-hash+ TypeScript compilation ofbuilder.addRedis(...). - Switches TypeScript E2E tests in this file from the legacy Docker install-mode detection to the newer
CliInstallStrategyflow. - Updates Docker terminal setup for the new scenario (uses the DotNet Dockerfile variant).
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16158Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16158" |
radical
reviewed
Apr 14, 2026
Member
radical
left a comment
radical
left a comment
There was a problem hiding this comment.
Review from multi-model analysis (Opus 4.6 + GPT 5.4). Two findings on the helper extraction and test completeness.
radical
approved these changes
Apr 14, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sebastienros
force-pushed
the
sebastienros/sebros-fix-ts-codegen-refresh
branch
from
bde8254 to
5853a63
Compare
Contributor
|
🎬 CLI E2E Test Recordings — 71 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #24463411621 |
Contributor
|
No documentation PR is required for this change. This PR adds test-only regression coverage (CLI E2E test) for the TypeScript SDK refresh bug (#15785). No product code was changed, no public APIs were added, and the existing documentation already covers the relevant behavior. The author also confirmed in the checklist that no docs update is needed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds CLI E2E coverage for the TypeScript guest AppHost flow behind issue #15785. The new test creates an app outside the repo so it uses
PrebuiltAppHostServer, installs Aspire throughCliInstallStrategy, addsAspire.Hosting.Redis, runsaspire restore, and then compiles anapphost.tsthat callsbuilder.addRedis("cache").This keeps the regression focused on the packaged/prebuilt path where stale SDK output was reported, and avoids false positives from string matching generated docs by proving the export is actually consumable from TypeScript. No product code changed because the refreshed SDK path passed once the scenario was modeled accurately.
Fixes #15785
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: