Fix AcrPurgeTask deployment test TypeScript API calls#16159
Merged
eerhardt merged 2 commits intomicrosoft:mainfrom Apr 14, 2026
Merged
Fix AcrPurgeTask deployment test TypeScript API calls#16159eerhardt merged 2 commits intomicrosoft:mainfrom
eerhardt merged 2 commits intomicrosoft:mainfrom
Conversation
Add missing 'await' on addAzureContainerAppEnvironment() and getAzureContainerRegistry() calls which return Promises in TypeScript. Also use positional args for withPurgeTask() instead of an options object to match the generated TypeScript SDK signature. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes the AcrPurgeTask deployment E2E test’s generated TypeScript AppHost script to correctly await async SDK calls and to invoke withPurgeTask using positional parameters expected by the TypeScript API.
Changes:
- Await
addAzureContainerAppEnvironment()andgetAzureContainerRegistry()to avoid calling methods on unresolved Promises. - Update
withPurgeTaskinvocation to use positional parameters (settingkeepvia the 4th argument).
eerhardt
commented
Apr 14, 2026
Member
Author
|
/deployment-test |
sebastienros
approved these changes
Apr 14, 2026
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16159Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16159" |
Contributor
|
🚀 Deployment tests starting on PR #16159... This will deploy to real Azure infrastructure. Results will be posted here when complete. |
Contributor
|
❌ Deployment E2E Tests failed — 26 passed, 4 failed, 0 cancelled View test results and recordings
|
radical
pushed a commit
that referenced
this pull request
Apr 14, 2026
* Fix AcrPurgeTask deployment test TypeScript API calls Add missing 'await' on addAzureContainerAppEnvironment() and getAzureContainerRegistry() calls which return Promises in TypeScript. Also use positional args for withPurgeTask() instead of an options object to match the generated TypeScript SDK signature. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Apply suggestion from @eerhardt --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the AcrPurgeTask deployment E2E test's TypeScript AppHost code to use proper
awaitand positional parameters.The test modifies
apphost.tsto add an Azure Container App Environment with a purge task. The TypeScript SDK methods return Promises and needawait, andwithPurgeTask()uses positional args (not an options object).Changes
awaitonaddAzureContainerAppEnvironment()andgetAzureContainerRegistry()callswithPurgeTask(schedule, filter, ago, keep)instead of{ keep: 1 }Verified
apphost.ts-- they all useawaitcorrectlyapphost.cs(C# AppHost viaaspire init) are unaffectedChecklist