Add analyzer for duplicate polyglot instance method names#16163
Draft
IEvangelist wants to merge 2 commits intomicrosoft:mainfrom
Draft
Add analyzer for duplicate polyglot instance method names#16163IEvangelist wants to merge 2 commits intomicrosoft:mainfrom
IEvangelist wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Warn when exported instance overloads collapse to the same generated polyglot method name, and cover the YARP-style addCluster case with focused analyzer tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16163Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16163" |
Hide the colliding auto-exposed HelmChartOptions overloads from ATS and replace them with union-backed exported helpers so Kubernetes keeps a single usable polyglot surface. Add a scanner test that pins the exported union helpers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15120.
Summary
Testing
$env:DOTNET_ROLL_FORWARD='Major'; dotnet test tests\Aspire.Hosting.Analyzers.Tests\Aspire.Hosting.Analyzers.Tests.csproj -- --filter-class "*.AspireExportAnalyzerTests" --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true"