ci(pr): Support PRs from forks for the spec review agent by using a pull_request_target workflow with a reusable workflow template. #15770
+149
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcilvaney
changed the title
dmcilvaney
force-pushed
the
damcilva/spec_agent_template
branch
7 times, most recently
from
8800a9f to
e2f4fcb
Compare
…ull_request_target workflow with a reusable workflow template.
dmcilvaney
force-pushed
the
damcilva/spec_agent_template
branch
from
e2f4fcb to
a1caced
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the spec review GitHub Actions setup to safely support pull requests from forks by switching to a pull_request_target stub workflow on the default branch that delegates work to a reusable workflow on tomls/base/main.
Changes:
- Convert
spec-review.ymlinto a reusableworkflow_callworkflow and keepworkflow_dispatchfor manual runs. - Add a
pull_request_targetstub workflow that calls the reusable workflow with PR metadata. - Implement sparse checkout + overlay of only
**/*.specfiles from the PR head repository/commit.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/spec-review.yml | Refactored into a reusable workflow; adds sparse checkout/overlay for PR head .spec files and updates PR-comment logic to use passed inputs. |
| .github/workflows/spec-review-stub.yml | New pull_request_target stub on default branch to invoke the reusable workflow with secrets available for fork PRs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simple spec review check can only safely run from non-fork PRs. This approach allows the check to run on all PRs.
It requires checking the stub yml into the default repo branch so that the workflow can trigger, but the rest of the workflow remains in the toml branch.