Skip to content

feat: Add Tooltip for necessary icons #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NirajC-Microsoft wants to merge 1 commit into from
Closed

feat: Add Tooltip for necessary icons #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/App/src/components/CartDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ export const CartDrawer = ({ cartItems, onUpdateQuantity, onRemoveItem, onChecko
icon={<ShoppingCart className="w-4 h-4" />}
className="relative transition-all duration-200"
onClick={() => onCartOpen?.()}
title="Shopping Cart"
>
{totalItems > 0 && (
<Badge
Expand Down
5 changes: 3 additions & 2 deletions src/App/src/components/Layout/PanelRightToolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React, { ReactNode } from "react";
import { Body1Strong, Button } from "@fluentui/react-components";
import eventBus from "./eventbus";
import { DismissRegular } from "@fluentui/react-icons";
import React, { ReactNode } from "react";
import eventBus from "./eventbus";

interface PanelRightToolbarProps {
panelTitle?: string | null;
Expand Down Expand Up @@ -79,6 +79,7 @@ const PanelRightToolbar: React.FC<PanelRightToolbarProps> = ({
icon={<DismissRegular />}
onClick={handleDismiss}
aria-label="Close panel"
title="Close"
/>
</div>
</div>
Expand Down
15 changes: 5 additions & 10 deletions src/App/src/components/ui/sheet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { ComponentProps } from "react"
import * as SheetPrimitive from "@radix-ui/react-dialog"
import XIcon from "lucide-react/dist/esm/icons/x"
import { ComponentProps } from "react"

import { cn } from "@/lib/utils"

Expand Down Expand Up @@ -70,7 +70,7 @@ function SheetContent({
{...props}
>
{children}
<SheetPrimitive.Close className="ring-offset-background focus:ring-ring data-[state=open]:bg-secondary absolute top-4 right-4 rounded-xs opacity-70 transition-opacity hover:opacity-100 focus:ring-2 focus:ring-offset-2 focus:outline-hidden disabled:pointer-events-none">
<SheetPrimitive.Close className="ring-offset-background focus:ring-ring data-[state=open]:bg-secondary absolute top-4 right-4 rounded-xs opacity-70 transition-opacity hover:opacity-100 focus:ring-2 focus:ring-offset-2 focus:outline-hidden disabled:pointer-events-none" title="Close">
<XIcon className="size-4" />
<span className="sr-only">Close</span>
</SheetPrimitive.Close>
Expand Down Expand Up @@ -126,12 +126,7 @@ function SheetDescription({
}

export {
Sheet,
SheetTrigger,
SheetClose,
SheetContent,
SheetHeader,
SheetFooter,
SheetTitle,
SheetDescription,
Sheet, SheetClose,
SheetContent, SheetDescription, SheetFooter, SheetHeader, SheetTitle, SheetTrigger
}

Loading