feat(react-combobox): add base hooks for Combobox and Dropdown#35915
Open
dmytrokirpa wants to merge 3 commits intomicrosoft:masterfrom
Open
feat(react-combobox): add base hooks for Combobox and Dropdown#35915dmytrokirpa wants to merge 3 commits intomicrosoft:masterfrom
dmytrokirpa wants to merge 3 commits intomicrosoft:masterfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Charts-DonutChart 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic - RTL.default.chromium.png | 5570 | Changed |
| vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png | 5581 | Changed |
| vr-tests-react-components/Charts-DonutChart.Dynamic - Dark Mode.default.chromium.png | 7530 | Changed |
vr-tests-react-components/Field 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Field.Combobox+horizontal.default.chromium.png | 6024 | Changed |
| vr-tests-react-components/Field.Dropdown+horizontal.default.chromium.png | 6002 | Changed |
| vr-tests-react-components/Field.Dropdown.default.chromium.png | 3582 | Changed |
| vr-tests-react-components/Field.Combobox.default.chromium.png | 3608 | Changed |
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default.submenus open.chromium.png | 605 | Changed |
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default - RTL.submenus open.chromium.png | 599 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 959 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 624 | Changed |
vr-tests-react-components/ProgressBar converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - High Contrast.default.chromium.png | 128 | Changed |
vr-tests-react-components/TagPicker 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - High Contrast.chromium.png | 1319 | Changed |
| vr-tests-react-components/TagPicker.disabled - RTL.disabled input hover.chromium.png | 635 | Changed |
There were 2 duplicate changes discarded. Check the build logs for more information.
1 task
📊 Bundle size report
Unchanged fixtures
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useComboboxBase_unstableforCombobox(omitsappearance,size;expandIcon/clearIconwithout default icon children)useDropdownBase_unstableforDropdown(omitsappearance,size;expandIcon/clearButtonwithout default icon children)ComboboxBaseHookProps,ComboboxBaseHookState,DropdownBaseHookProps,DropdownBaseHookStatefrom package index*HookProps/*HookStatesuffix to avoid conflict with existingComboboxBaseProps/ComboboxBaseStatetypes (shared internal state between Combobox and Dropdown)Listbox,Option,OptionGroupskipped — no design-only state propsPart of the base state hooks RFC: docs/react-v9/contributing/rfcs/react-components/convergence/base-state-hooks.md
Test plan
tsc --noEmit)🤖 Generated with Claude Code