MsGraphicsPkg/SwmDialogsLib: Show OSK after dialog rendering completes#866
Merged
makubacki merged 1 commit intomicrosoft:release/202511from Apr 9, 2026
Merged
Conversation
apop5
approved these changes
Apr 2, 2026
os-d
approved these changes
Apr 2, 2026
Moves the `ShowKeyboard()` call after the canvas `Draw()` call in the `KEYFOCUS` handling block of PasswordDialog and SemmUserAuthDialog. Previously, the on-screen keyboard was displayed before the dialog finished rendering at its shifted position, which could result in visual overlap between the OSK and the partially rendered dialog. By deferring `ShowKeyboard()` until after `Draw()` completes, the dialog is fully painted in its final position before the keyboard appears. Co-authored-by: Wenbo Hou <wenbhou@microsoft.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
force-pushed
the
msgfxpkg_swmdialogslib_osk_rend
branch
from
53d3cae to
320367d
Compare
Contributor
✅ QEMU Validation PassedSource Dependencies
Results
Workflow run: https://github.com/microsoft/mu_plus/actions/runs/24166098853 This comment was automatically generated by the Mu QEMU PR Validation workflow. |
kuqin12
approved these changes
Apr 9, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves the
ShowKeyboard()call after the canvasDraw()call in theKEYFOCUShandling block of PasswordDialog and SemmUserAuthDialog.Previously, the on-screen keyboard was displayed before the dialog finished rendering at its shifted position.
By deferring
ShowKeyboard()until afterDraw()completes, the dialog is fully painted in its final position before the keyboard appears.How This Was Tested
Integration Instructions