Merged
Conversation
Collaborator
gramalingam
commented
Mar 4, 2026
gramalingam
commented
- The subgraph construction utility extended to allow specification of input/output names as well (optionally).
- The to_ir method renamed to to_ir_type_and_shape in TensorType (for more robust duck-typing/protocol typing)
Add OpBuilder to __all__ and import it from _internal.builder in the top-level onnxscript package. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…graph - Extract core subgraph-building logic into module-level build_graph() - Rename input_types/output_types params to inputs/outputs - Accept dict (named) or list (auto-named) for inputs/outputs - Rename TensorType.to_ir() to to_ir_type_and_shape() - Use duck typing in _resolve_type_spec with return type validation - Update docs and tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…graph - Extract core subgraph-building logic into module-level build_graph() - Rename input_types/output_types params to inputs/outputs - Accept dict (named) or list (auto-named) for inputs/outputs - Rename TensorType.to_ir() to to_ir_type_and_shape() - Use duck typing in _resolve_type_spec with return type validation - Update docs and tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…xscript into rama/build-utility
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2842 +/- ##
==========================================
+ Coverage 71.78% 71.81% +0.03%
==========================================
Files 239 239
Lines 29014 29054 +40
Branches 2863 2866 +3
==========================================
+ Hits 20827 20865 +38
- Misses 7216 7217 +1
- Partials 971 972 +1 ☔ View full report in Codecov by Sentry. |
justinchuby
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.