ci: no unstable test helpers in vmgstool releases#2848
ci: no unstable test helpers in vmgstool releases#2848tjones60 wants to merge 3 commits intomicrosoft:mainfrom
Conversation
|
What tests depend on these test helpers? Are we not running those tests in the release CI? |
smalis-msft
added
the
release-ci-required
Nevermind, I do use the test helpers in vmm tests. Maybe I should just build both, won't take long. |
tjones60
changed the title
tjones60
changed the title
tjones60
force-pushed
the
vmgstool_release_notesthelpers
branch
from
af6cce4 to
0b693a6
Compare
tjones60
force-pushed
the
vmgstool_release_notesthelpers
branch
from
0b693a6 to
fe17add
Compare
| pipeline.new_typed_artifact(format!("{arch_tag}-windows-ohcldiag-dev")); | ||
|
|
||
| let job = pipeline | ||
| let vmgstool_release = release.then(|| { |
There was a problem hiding this comment.
Do we want this on all release builds, or just CI builds? Like this doesn't need to happen in the pr-release flow right?
There was a problem hiding this comment.
I thought it might be useful to build the release version in PR release so that it would catch if there was some weird build issue with the feature disabled. I still only gets published on actual PR runs.
There was a problem hiding this comment.
If we want to catch that then we should be building it always, PR release rarely gets run.
There was a problem hiding this comment.
I did it this way since I figured it only happen occasionally when people are messing with the test helpers but I guess building it every time would be reasonable. In that case it might make sense to have two vmm-tests artifacts so we are testing the actual thing when we can.
Release versions of vmgstool shouldn't include the unstable test helpers. Build a version without the feature to publish, while still building with the feature for VMM tests.