ci: associate vmgstool github release with current commit#2861
Merged
tjones60 merged 2 commits intomicrosoft:mainfrom Mar 10, 2026
Merged
ci: associate vmgstool github release with current commit#2861tjones60 merged 2 commits intomicrosoft:mainfrom
tjones60 merged 2 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Flowey GitHub release publishing node to create and push a git tag before creating a (draft) GitHub release, aiming to ensure the release is tied to the intended commit.
Changes:
- Create an annotated git tag for the release version.
- Push the tag to
originprior to invokinggh release create.
benhillis
previously requested changes
Feb 27, 2026
Member
benhillis
left a comment
benhillis
left a comment
There was a problem hiding this comment.
I wonder if it might be better to have a flow where:
- The CI job pushes the tag
- A separate workflow publishes the release (triggered by tags)
benhillis
reviewed
Mar 2, 2026
Member
benhillis
left a comment
benhillis
left a comment
There was a problem hiding this comment.
I've decided I am ok with this approach, but I think copilot found a couple real issues that should be fixed.
tjones60
force-pushed
the
vmgstool_git_tag
branch
from
bf3de4a to
0383c15
Compare
tjones60
changed the title
benhillis
approved these changes
Mar 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associate the (draft) GitHub release for VmgsTool with the current commit using the
--targetargument.