Skip to content

fix: Browser.IsConnected should be updated when connection closes #3285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgozman merged 1 commit into from
Mar 24, 2026
Merged

fix: Browser.IsConnected should be updated when connection closes #3285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Playwright/Core/Browser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,14 @@ internal class Browser : ChannelOwner, IBrowser
internal string? _tracesDir = null;
internal BrowserType _browserType = null!;
internal string? _closeReason;
private readonly EventHandler<Exception> _onConnectionClose;

internal Browser(ChannelOwner parent, string guid, BrowserInitializer initializer) : base(parent, guid)
{
IsConnected = true;
_initializer = initializer;
_onConnectionClose = (_, _) => DidClose();
_connection.Close += _onConnectionClose;
}

public event EventHandler<IBrowser>? Disconnected;
Expand Down Expand Up @@ -286,6 +289,11 @@ private void DidCreateContext(BrowserContext context)

internal void DidClose()
{
if (!IsConnected)
{
return;
}
_connection.Close -= _onConnectionClose;
IsConnected = false;
Disconnected?.Invoke(this, this);
_closedTcs.TrySetResult(true);
Expand Down
Loading