Fix bidi screenshot quality=0 being treated as 80%#39744
Merged
yury-s merged 1 commit intomicrosoft:mainfrom Mar 19, 2026
Merged
Fix bidi screenshot quality=0 being treated as 80%#39744yury-s merged 1 commit intomicrosoft:mainfrom
yury-s merged 1 commit intomicrosoft:mainfrom
Conversation
bidiPage.ts uses a truthy check (quality ? quality / 100 : 0.8) to convert the screenshot quality parameter. When quality === 0, this evaluates to 0.8 (80%) instead of 0.0. Change to quality !== undefined ? quality / 100 : undefined, which correctly handles zero and omits quality for PNG screenshots.
yury-s
approved these changes
Mar 18, 2026
Contributor
Test results for "MCP"5481 passed, 343 skipped Merge workflow run. |
Contributor
Test results for "tests 1"1 failed 5 flaky38822 passed, 845 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bidiPage.tsuses a truthy check (quality ? quality / 100 : 0.8) to convert the screenshot quality parameter from 0–100 scale to 0–1 scale for the BiDi protocol. Whenquality === 0, the check fails (0 is falsy) and the value becomes0.8(80%) instead of0.0.quality ?? 80as the default inscreenshotter.ts, but the bidi implementation was not updated to match — it still uses its own0.8fallback via a truthy check.qualitythrough directly, so0works correctly.quality !== undefined ? quality / 100 : undefinedquality === 00.8fallback (already handled upstream by?? 80)qualityfor PNG screenshots (qualityis optional in the BiDi protocol)Test plan
quality option should work for jpeg— verifiesquality: 0produces a smaller file thanquality: 100